dylanwal / plotly_gif

Generate .gif from your Plotly figures

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Relative imports for `requirements.txt`

Anselmoo opened this issue · comments

@dylanwal very nice and helpful plugin

I was wondering if it might be possible to replace the == pinned requirements with >= relative imports?

Pillow==9.0.0
plotly==5.5.0
kaleido==0.2.1
numpy==1.21.6

Adding support for poetry in addition to pyproject.toml could enhance compatibility.

Hi @Anselmoo thanks for reaching out!

It was my understanding that the 'requirements.txt' should be == and the 'setup.cfg' uses >='. I believe the rational behind this is that when the package is pip` installed it gets versions from 'setup.cfg' and the user will get the most up-to-date versions. The 'requirements.txt' is there as a back-up in case there was breaking changes in dependances and for development. If you have a different perspective on this, let me know.

With regard to poetry: I haven't used that package manger before (I am aware of it), and I can look into adding that next week or if that's something you can put together I would be happy to accept the pull request.

Dear @dylanwal,
Thank you very much for your feedback! Sorry, I wasn't aware about requirements.txt vs. setup.cfg. You are right, https://pypi.org/project/plotly-gif/#files is only taking the setup.cfg.

image

However, I am happy to make PR for Poetry as package manager, so you can take a look.