shortid.generate(), broken!

Question

shortid.generate(), broken!

latifs opened this issue 6 years ago · comments

Hi guys,

I'm using shortid in my react app, specifically in a component that deals with generating "quotes" (as in prices).

I'm using shortid.generate() to create a unique id for the items in the quote.
import shortid from 'shortid'; const item = { id: shortid.generate(), ...

Ever since the recent update though , this breaks the app and I get a:
Uncaught TypeError: Cannot read property 'id' of undefined

Any Idea why?
Thanks

Andrey Sitnik · Answer 1 · Thu Jul 12 2018 16:18:34 GMT+0800 (China Standard Time)

Hi. Can you show stack trace? The full error text?

Also I need your browser.

Latif.S · Answer 2 · Fri Jul 13 2018 00:21:46 GMT+0800 (China Standard Time)

Hi @ai,
I use Chrome Version 67.0.3396.99 (Official Build) (64-bit).
but the same thing happen in Safari too.

And here is the message I get from chrome that prevents the page to load fully:

2cb37cf63063697274b0d94ad88c72992efe856b.js:27 Uncaught TypeError: Cannot read property 'id' of undefined at cluster-worker-id.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:27) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at index.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:27) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at index.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:27) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at AddToQuote.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:77) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at ProductDetail.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:73) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at index.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:73) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at routes.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:82) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at MainApp.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:82) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at main.js (2cb37cf63063697274b0d94ad88c72992efe856b.js:82) at fileEvaluate (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at require (2cb37cf63063697274b0d94ad88c72992efe856b.js:1) at 2cb37cf63063697274b0d94ad88c72992efe856b.js:82

Thanks for your help.

Latif.S · Answer 3 · Fri Jul 13 2018 00:42:11 GMT+0800 (China Standard Time)

@ai,
I tried right now in package.json to replace:
"shortid": "^2.2.8"
with
"shortid": "2.2.8"

now the page loads and the error is gone,
so probably something with shortid 2.2.11

Andrey Sitnik · Answer 4 · Fri Jul 13 2018 03:30:19 GMT+0800 (China Standard Time)

I will fix it after few hours.

Latif.S · Answer 5 · Fri Jul 13 2018 04:03:59 GMT+0800 (China Standard Time)

@ai Thanks!

Andrey Sitnik · Answer 6 · Fri Jul 13 2018 05:09:13 GMT+0800 (China Standard Time)

Should be fixed in 2.2.12

(BTW, you have something bad without your JS bundle, you shouldn’t see this file)