Chore: Review all the open Pull Requests and Attempt to merge them π§βπ»
nelsonic opened this issue Β· comments
At present there are 20
open Pull Requests: https://github.com/dwyl/english-words/pulls
This is both a great and a really bad sign. π π
On the positive side it's awesome that people want to contribute to the project
[not just take the words and give nothing back...]
and continually renews my faith in Open Source! π
But the down-side of having so many PRs open is that the efforts of several people are wasted ... π
ewe need to do a much better job of communicating how to contribute.
#130 is an example of one that clearly took some effort and will add value to people! π
So we need to make every effort to ensure that the effort was not wasted! β³
Note: this is
priority-3
("nice to have") becausewhile
we definitely want to maintain and improve this repo, we have extremely limited time. And since we are not currently using it in ourApp
... we cannot justify the time allocation/investment right now. That's why I've "ignored" the open PRs. π
Only features that relate to theApp
are given higher priority.
It's possible that we could use English Words in the App e.g. for auto-completion/suggestion.
In which case the priority of updating/maintaining this repo/project would be raised.
Todo
-
Review the PR: π
- Assign it to yourself and add the label:
in-review
π¨βπ« - View the code/words updates and leave comments π¬
- If you feel it's immediately mergeable, approve it and assign it to me. π
- If it's not mergable, please leave a comment for the author (including an apology for the delay and link to this issue) π
- Assign it to yourself and add the label:
-
Criteria that qualifies for merging:
- Minor code change where CI passes. β e.g: #153
- Word change that references an issue where it was previously discussed. β
-
Instantly reject PRs that update
Zip
files and explain thatZip
files files are commonly used for viruses so we cannot afford to trust anyone with updating them. "It's not you, it's me/us" we "Trust No One" https://en.wikipedia.org/wiki/Trust_no_one_(Internet_security)
@LuchoTurtle you mentioned this repo to me verbally in our catch up yesterday.
If you want to make a stab at reviewing the open PRs in a Pomodoro Break, go for it!
Please just leave a comment on this issue first and link to the PR you're picking off.