Support for composer tag
s-fleck opened this issue · comments
While composer (and possibly performer) tags are really obscure in most genres of music, they are pretty essential to keep a classical music collection organized IMHO. Support for these is lackluster, but as far as i could find the opensubsonic API spec includes it (see links below)
https://opensubsonic.netlify.app/docs/responses/child/
https://opensubsonic.netlify.app/docs/responses/artistid3/
I've been trying to get around this using the Album Artist and Artist tags, but it's getting pretty confusing and doesn't work all that well :(. I'm also not sure how many server support that tag, probably not yet a lot, but it has to start somewhere (i also submitted a similar feature request to my favourite airsonic server gonic)
I'm also not sure how many server support that tag
LMS supports composer and performer tags:
(I use LMS via Supersonic)
Oh so you are saying supersonic already supports the tag (also for searching?). in that case i can close that issue again i guess.
Supersonic doesn't support the composer tag yet - and I'm not sure the OpenSubsonic APIs are rich enough yet to do anything but add it as a tracklist column. @alessandrococco if you search for a composer who is not tagged as [Album]Artist in any tracks but only composer, does it show up as an "Artist" in Supersonic? If so, maybe I can work with the APIs as they are; if not then there's nothing I can do right now other than make Composer a non-hyperlink tracklist column
The getArtists response contains info about roles:
(ignore the wrong album count, it's a LMS bug - fixed but unreleased)
if you search for a composer who is not tagged as [Album]Artist in any tracks but only composer, does it show up as an "Artist" in Supersonic?
Yes! I added a composer to an album (
) and it appears in the artists view:
but it does not appear in the album view (I added PIPPO as a composer for all tracks in this album):
@alessandrococco what does the "artist" page for the PIPPO "artist" look like in this case? I see that Supersonic shows it as "11 albums" - I wonder if LMS is reporting each track as an album for composers?
@alessandrococco what does the "artist" page for the PIPPO "artist" look like in this case?
Like a normal artist page:
I see that Supersonic shows it as "11 albums" - I wonder if LMS is reporting each track as an album for composers?
It was a LMS bug, now it has been fixed
@alessandrococco if you get a chance, would you be able to test one of the Github Actions builds from the composer PR https://github.com/dweymouth/supersonic/actions (or built from source on the feature/composer branch)? LMS is the only server that supports composer currently and I don't have an LMS instance at the moment. But as long as LMS follows the OpenSubsonic spec, the implementation should work...
Tested and working against the LMS demo server, merged for next release!
many thanks for the quick implementation!
@alessandrococco if you get a chance, would you be able to test one of the Github Actions builds from the composer PR https://github.com/dweymouth/supersonic/actions (or built from source on the feature/composer branch)?
Sorry, I was busy with my family over the weekend 😅
Tested and working against the LMS demo server, merged for next release!
Great, thanks!