dvershinin / lastversion

Find the latest release version of an arbitrary project

Home Page:https://lastversion.getpagespeed.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bad URL decoding on tags leading to wrong major version

TheBlusky opened this issue · comments

Hi ! Pretty nice work on this module, letting me auto update dependencies on projects.

I came accross a bug on some repositories, for eg., when I do python -m lastversion n8n-io/n8n, I get 400.222.3 as a result, but it should be 0.222.3 (as of 2023/04/24).

When digging why I get this behavior with verbose, I have the following line :

lastversion.GitHubRepoSession - INFO - Got HTTP status code 200 from https://api.github.com/repos/n8n-io/n8n/releases/tags/n8n%400.223.3

So n8n%400.223.3 is interpreted as 400.223.3 instead of 0.223.3 because %40 is treated as 40 instead of @ (url decoding)

@TheBlusky that is fixed in the latest release. Please try it out.

I can confirm that it's now fixed. Thank you for your reactivity :-)

Thanks !