do not force to set setTitles() in a Builder

Question

do not force to set setTitles() in a Builder

hardysim opened this issue 7 years ago · comments

Simon Hardt commented 7 years ago

from #28 (comment)

if needed I think the constructor would be a better place

Davide Cirillo · Answer 1 · Tue Jan 31 2017 01:49:00 GMT+0800 (China Standard Time)

Where am i forcing to set the title?

Simon Hardt · Answer 2 · Tue Jan 31 2017 16:46:55 GMT+0800 (China Standard Time)

The MultiChoiceToolbar#Builder() takes setTitles().
If I do not add this to the builder, it crashes with:

Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.String.trim()' on a null object reference
at com.davidecirillo.multichoicerecyclerview.MultiChoiceToolbar.<init>(MultiChoiceToolbar.java:26)
at com.davidecirillo.multichoicerecyclerview.MultiChoiceToolbar.<init>(MultiChoiceToolbar.java:9)
at com.davidecirillo.multichoicerecyclerview.MultiChoiceToolbar$Builder.build(MultiChoiceToolbar.java:122)

In my understanding, a builder is the thing where I might add options (but I can leave them unset).
Am I wrong?

This is not a bug - more like a architectural discussion ;-)

Davide Cirillo · Answer 3 · Tue Jan 31 2017 16:47:58 GMT+0800 (China Standard Time)

Correct, thanks for adding info, will fix this later