Which branch should I submit to?

Question

Which branch should I submit to?

cannian1 opened this issue 7 months ago · comments

残念 commented 7 months ago

In contributing-guide, It mentioned to submit to the v2 branch.

But the v2 branch doesn't have GitHub Actions.

Like #145 , PR may fail in test.

duke-git · Answer 1 · Wed Feb 28 2024 19:47:21 GMT+0800 (China Standard Time)

In contributing-guide, It mentioned to submit to the v2 branch.

But the v2 branch doesn't have GitHub Actions.

Like #145 , PR may fail in test.

Yes, the current branch management is not standardized. To solve this problem, I suggest creating a release candidate (rc) branch to release the next version lib. All PRs should request be merged into the RC branch. At the same time, the rc branch uses GitHub Actions to run unit test tasks. After release, the rc branch will be merged into the main branch.

残念 · Answer 2 · Wed Feb 28 2024 21:28:22 GMT+0800 (China Standard Time)

I think this is feasible, so when would be a good time to start?

Does anyone have any other suggestions?

duke-git · Answer 3 · Thu Feb 29 2024 11:34:27 GMT+0800 (China Standard Time)

I think this is feasible, so when would be a good time to start?

Does anyone have any other suggestions?

I created the rc branch for release candidate. All PRs should be merged into the rc branch. The main branch will be frozen.