ducttape / ducttape-engine

Ducttape Engine - A universal game engine

Home Page:http://ducttape-dev.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename MessageEvent::GetMessageEvent() to GetMessageText

opatut opened this issue · comments

... and fix all occurrences.

Timer and ChatMessageEvent also have GetMessageEvent() method, should it be renamed, too?

Well, I noticed it does not inherit from ChatMessageEvent, even though it should... Could you do that as well? Make sure to call MessageEvent's constructor in the initializer list of ChatMessageEvent, then.

I was adding to ChatMessageEvent the inheritance from MessageEvent, but it causes a diamond. Virtual inheritance seems to work fine, should I add it?

I see that diamond... If it works, it is fine! Go ahead.