duckduckgo / zeroclickinfo-goodies

DuckDuckGo Instant Answers based on Perl & JavaScript

Home Page:https://duckduckhack.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

sun_info Bug: Wrong sunset time

hannorein opened this issue · comments

Description

The time for sunset in Toronto is off by one hour. I suspect this is due to a timezone issue.

Screen Shot 2020-04-24 at 7 23 27 PM

Steps to recreate

Search for "Sunset in Toronto"

People to notify

Maintainer: @Mailkov

People to notify


Instant Answer Page: https://duck.co/ia/view/sun_info

Thanks for reporting. Hoping to fix this shortly. We're apparently missing a check for Daylight Savings 👍

For reference, reported on Reddit too:
When I search for "sunrise", DDG gives me a time for sunrise and sunset. The times it gives, however, are incorrect. They are off by an hour. It seems the algorithm doesn't take daylight saving time into account.
https://www.reddit.com/r/duckduckgo/comments/gbi2gv/sunrise_time_incorrect/