Please add site --> https://crimsontranslations.com/
plsbenice-immadeofjelly opened this issue · comments
Provide URL for web page that contains Table of Contents (list of chapters) of a typical story on the site
https://crimsontranslations.com/7-i-made-the-horror-game-boss-fall-for-me
Did you try using the Default Parser for the site? If not, why not?
Yes, I did, but I no CSS Selector worked at all no matter what input I entered because I couldn't use the "Test" function since the same error kept showing up: You need to enable Javascript to run this app.
I'm not sure if this site is parsable because I recall encountering this issue before with another site when I tried to use the Default Parser (from issue #1266) but was hoping to see if there was a possible workaround to this new issue because the layout for this source doesn't seem as complex :D Thank you for your time and efforts~
@plsbenice-immadeofjelly
Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:
For my notes: 30 minutes work
Thank you very much!! :) Although it did indeed work to pull in all the chapter content, there's a slight error, which I hope is not too troublesome. For some reason, the entire body content is only wrapped in one singular paragraph element, causing each chapter to be congregated into one large wall of text, whereas on the novel's source itself, each paragraph was properly separated per line. May I ask if this fix is able to be incorporated into the parser of this site? But, regardless, thank you very much for your help! :D
EDIT: Actually, it seems like some novels were properly wrapped in separate paragraph tags per line, like for "https://www.crimsontranslations.com/6-i-pretended-to-be-a-couple-with-my-rival-and-it-became-true".
But, there were other novels that had a different format, which caused the above mentioned error in only having one paragraph element, such as:
https://www.crimsontranslations.com/5-sea-salt-mint-and-freesia
https://www.crimsontranslations.com/3-my-boyfriend-lost-his-memory-and-is-madly-pursuing-me-again
Though, after a perusal of this site's novels, it seems this formatting issue only affects the old entries, not the latest novels, so this negligible error can be written off as inconsequential at best, so it's completely okay if there's no time to redress this issue~ :) Thank you again!
Apologies. This site does not include the content text in the HTML. Instead a REST call is needed, and I have to construct the HTML from the JSON. In this case, some of the chapters have slightly different formatting, so the JSON to HTML conversion doesn't quite work. I believe I have it fixed now.
Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:
For my notes: 45 minutes work (running total)
Updated version (0.0.0.159) is now available from Firefox and Chrome stores.
Hello! I'm really super sorry for the bother again, but for some reason, this site completely stopped working today... The older stories I tried that Webtoepub had worked on before when the parser was edited also no longer work... It didn't seem to be a connectivity issue with my network, so I think the site layout might have something different which interferes with the current configurations of the parser? I also tried creating an epub on Mozilla Firefox and, unlike Chrome, the following error cropped up:
json.content is undefined jsonToHtml@moz-extension://0dc5c741-41ff-404d-9de4-81b3901dcb49/js/parsers/CrimsontranslationsParser.js:39:26
fetchChapter@moz-extension://0dc5c741-41ff-404d-9de4-81b3901dcb49/js/parsers/CrimsontranslationsParser.js:30:24
I'm really sorry for the trouble and thank you much again!
Yes, that error message is computer speak for site has changed it's layout.
More specifically, site has changed the JSON schema of the REST call used to return chapter content. But that distinction probably means nothing to you.
Anyway, I'll look into it shortly.
Also, in future, please raise a new issue for something like this, rather than add comments to an existing closed one. It makes it easier for me to track things. (I've made an exception in this case.)
Thank you for looking into this error :) I'm sorry for adding on the inconvenience, I'll be sure to open a different issue, should a problem with an existing source crop up. But, thank you for making an exception~
I'm sorry for adding on the inconvenience,
No problem.
Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:
For my notes: 8 minutes work
Reopen. I need to tell you when version in store is updated.
Thank you!!!! It works again!!! :D
Updated version (0.0.0.160) has been submitted to Firefox and Chrome stores.
Firefox version is available now.
Chrome might be available in a few hours to 21 days.