max_speed && speed problem
beyoung opened this issue · comments
fit file:
2019-2-13-10-36-52-12791.fit.zip
fitparse version 1.0.1
max_speed : 14.201
fitparse version 1.1.0
max_speed: 14201
and speed encounter the same problem.
As I dive into detail, I found that bug is caused by generate_profile.py script, in line 468, which wipe out scale, offset and units.
But I think that only in situation of components scale is None or b'' or is not digit(
), we can wipe out scale, offset and units. so, wipe code should be
. If you agree with me, I'd make a PR.
Hi, we've been happy users of this library for a while. We recently encountered an issue that is resolved by this work around which is available in 1.1. However, the bug described in this issue is preventing us from moving to 1.1. Any idea when this change will make it to a release that we can install with pip?
Thanks a lot for all the work on this library.
@cberthiaume You can create a new issue to detail your problem.
I'm confused, the issue in this issue is my problem. I see it's been merged. I'd just like to know when it will be released.
@cberthiaume, you're able to install it from pip immediately. Just use the latest SHA, see this post on Stack Overflow.
Excellent, thanks @dtcooper!