Feature request: avoid source code

Question

Feature request: avoid source code

hmijail opened this issue 4 years ago · comments

Horacio Mijail Antón Quiles commented 4 years ago

I find that pages which contain source code tend to get (parts of) it highlighted, which makes no sense. Additionally, it also seems to throws off the highlighting on the rest of the page.

So it'd be great if there was any possibility of avoiding source code when considering what to highlight; or if that's too hard / impossible, then to just disable highlighting if source code is detected.

As for how to detect source code, as a first guesstimation, I'd imagine that if there is some block of monospaced text, that's suspicious enough.

Daniel Steinberg · Answer 1 · Sat Nov 07 2020 02:26:56 GMT+0800 (China Standard Time)

HI @hmijail. Do you have particular example pages that you can share? That would help for devising a workaround and testing that it works.

Horacio Mijail Antón Quiles · Answer 2 · Sat Nov 07 2020 15:59:58 GMT+0800 (China Standard Time)

A couple of examples:
https://golang.org/ref/spec
https://docs.python.org/3/library/argparse.html
http://lamport.azurewebsites.net/tla/peterson.html?back-link=high-level-view.html#pluscal?unhideBut@EQhide-pluscal@AMPunhideDiv@EQpluscal

Daniel Steinberg · Answer 3 · Wed Nov 18 2020 06:20:02 GMT+0800 (China Standard Time)

@hmijail, thanks for reporting the issue and providing the examples!

I've added a workaround that excludes text from consideration if it's in a <pre> tag and the page is not primarily comprised of such text. This handles the examples you've shared. Please let me know if you encounter any additional examples that remain problematic, or any pages that you believe this update may have introduced a new problem on.

I've submitted the updated extension to Chrome, Firefox, and Edge. It has been approved for Chrome and Firefox, and the review is still pending for Edge (it can take up to a few days, based on prior experience).