PHPMD errors in workflow since merge into main PHP job
dshoreman opened this issue · comments
Since the PHP CS and SA tools were all moved into the main job in #350, PHP MD is now able to run under 7.4 again thus it's throwing a bunch of errors.
For some reason node_modules/ is now being scanned (or simply didn't contain any PHP files previously) so we need to add that to the list of excludes.
There will also be a ton of new "unused variable" errors, and some CamelCase ones caused by usage of
$_ to silence Phan. To workaround these errors, we should create our own Rule Set.