[SPProductUpdate] Resource does not support SPSE yet

[Yorick Kuijs]

Problem description

This resource is not yet updated to support Subscription Edition. On various places in the code, 2019 is referenced instead of SPSE:

SharePointDsc/SharePointDsc/DSCResources/MSFT_SPProductUpdate/MSFT_SPProductUpdate.psm1

Lines 737 to 755 in a98dfeb

 function Get-SPDscLocalVersionInfo 
 { 
     [OutputType([System.Version])] 
     param 
     ( 
         # Parameter help description 
         [Parameter(Mandatory = $true)] 
         [ValidateSet(2013, 2016, 2019)] 
         [System.Int32] 
         $ProductVersion, 
  
         [Parameter()] 
         [System.Int32] 
         $Lcid, 
  
         [Parameter()] 
         [Switch] 
         $IsWssPackage 
     ) 

SharePointDsc/SharePointDsc/DSCResources/MSFT_SPProductUpdate/MSFT_SPProductUpdate.psm1

Lines 116 to 130 in a98dfeb

 if ($fileVersionInfo.Major -eq 15) 
 { 
     $sharePointVersion = 2013 
 } 
 else 
 { 
     if ($fileVersionInfo.Build.ToString().Length -eq 4) 
     { 
         $sharePointVersion = 2016 
     } 
     else 
     { 
         $sharePointVersion = 2019 
     } 
 } 

This is causing the resource not to detect installed updates correctly and therefore trying to install already installed updates again and failing.

Verbose logs

Not available

DSC configuration

Not available

Suggested solution

Update the resource to support SPSE

SharePoint version and build

SPSE

Operating system the target node is running

Any supported OS

PowerShell version and build the target node is running

v5.1

SharePointDsc version

dev