dsccommunity / DnsServerDsc

This module contains DSC resources for the management and configuration of Windows Server DNS Server.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BREAKING CHANGE: xDnsServerSetting: Remove properties LogIPFilterList, LogFilePath, LogFileMaxSize, and EventLogLevel

johlju opened this issue · comments

Details of the scenario you tried and the problem that is occurring

Suggest removing the property LogIPFilterList in favor of the already present property FilterIPAddressList in the resource xDnsServerDiagnostics to avoid ping-pong behavior. This will also simplify the resource xDnsServerSetting.

Verbose logs showing the problem

Not available.

Suggested solution to the issue

Remove the property LogIPFilterList and use the resource xDnsServerDiagnostics to enforce this setting instead.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

Configuration xDnsServerSetting_CurrentNode_Config
{
    Import-DscResource -ModuleName 'xDnsServer'

    Node localhost
    {
        xDnsServerSetting 'SetIpFilterList'
        {
            DnsServer       = 'localhost'
            LogIPFilterList = @('168.63.129.16', '168.63.129.18')
        }

        xDnsServerDiagnostics 'Diagnostics'
        {
            DnsServer           = 'localhost'
            FilterIPAddressList = @('10.0.10.1', '10.0.10.2')
        }
    }
}

The operating system the target node is running

Any Windows

Version and build of PowerShell the target node is running

Windows PowerShell 5.1

Version of the DSC module that was used

2.0.0

We should also remove the properties LogFilePath and LogFileMaxSize too. They can be enforced by the resource xDnsServerDiagnostics with the properties LogFilePath and MaxMBFileSize.

Also remove the properties EventLogLevel. It can be enforced by the resource xDnsServerDiagnostics with the properties EventLogLevel.