Update Cycle
jwarkentin opened this issue · comments
It would be helpful if you updated to the latest version that includes the fix for properly handling functions in objects. See douglascrockford/JSON-js#50.
Please do send a PR. Thank you
Really?! In maintaining this repo, literally the only thing you have to do is keep it in sync with Crockford's. I understand if you don't go and look all the time to see if there's been an update, hence I created this issue to inform you. If you aren't interested in maintaining it for NPM, then perhaps you should hand the reins to someone else. Just a thought.
Yes, really.
Appreciated the feedback but as stated before if you want this merged please send as a PR. You will be added to the contributors and credited for those changes. And everyone using cycle would thank you.
"The only thing (I) have to do" is maintaining many (~hundreds) open source libraries. I (and my previous company) wrote a lot of the code you probably use everyday in your projects if you code in nodejs. You do that for free. I maintain some of those projects and make sure quality is not compromised: having to go thru hundreds of code changes and making sure a clumpsy/lazy/etc developer does not ruin everyone's time. This is voluntary work, but very time consuming. It is not fun work, I do it to help everyone and because I love open source software. But I do it within my comfort zone and within what I am willing to do. And the contributing guidelines set the rules for everyone to play nicely together.
Also how I best spend my time is up to me, and while you can have an opinion I don't necessarily agree. Neither you get to control that. I'm sorry.
I ask that you try to contribute as much to the open source ecosystem as others have in the past few years. It will be fun, you will learn a lot, and you are doing genuine good. But after you do so, come back here and let me know how you stand. If you still feel it's so outrageous that someones say "if you care for it, send me the PR and I'll merge it and publish it for you"
I don't mean this as being condescending, it just seems like you underestimate the amount of (free) work that goes into FOSS. Learn by doing, it's a great thing to do.
Related
- apache/nano#167 (comment)
- http://writings.nunojob.com/2012/05/My-Contribution-to-JSConf-2012-The-Good-And-The-Bad-Open-Source.html
PS. I understand writing this took longer than doing the fix but I do hope that after this response you send me a PR and we can all be happy and understand that open source is about collaboration not entitlement.
I already sent the PR about 2 minutes after that comment. And for what it's worth I maintain my own open source projects as well as contribute a lot to many others. I understand that you have a lot on your plate. I don't mean this to sound rude in any way. The only point I was getting at is that if you don't have the time to simply update the library (which only took a couple minutes to fork it, checkout both repos, copy, push and create a pull request), then maybe you should consider letting someone else help to maintain it.
I just feel that anyone who maintains open source software that is widely used/depended on has some responsibility to maintain it or let someone else do so. It wouldn't be the same if I fork it because no one would depend on the one I fork, they depend on the one you maintain. Hence the suggestion to pass it on if you can't maintain. It's just the responsible thing to do, IMO.
Thanks for the feedback @jwarkentin – btw I'm already replying to your PR :)
Thanks. I hope I didn't offend you by what I said. BTW, Crockford's cycle.js is actually one of the many FOSS projects I've contributed to :) That's the only reason I went to the effort to try and get this updated. It has my fix that I referenced above which is really important for my own FOSS project that I maintain that uses it. For now I just keep a modified copy of cycle.js committed with my repo until this update is in NPM.
@jwarkentin you offended me, and I don't even have anything to do with this repo. You need to carefully consider why and what you write here. Lots of different people will note your very rude behaviour. Don't worry about everybody else and what they should or should not do. Worry about your self.
@hallas I still stand by my point, though I admit I could have been more tactful. The fact that you chose to take offence where none was given (and I clarified that none was intended) is on you. That's a matter of subjective opinion. I've found that someone will always find a way to be offended, often even from the most innocent of statements. I can't help that.
@jwarkentin that is probably true :-)