dscape / cycle

Fork of crocs cycle package that lives in npm

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Using eval necessary?

danielkcz opened this issue · comments

Based on SocketCluster/sc-errors#1

I am not entirely sure what this module does that it needs to use eval, but everyone kinda warns against using it like this.

The rollup recommends to grab store reference to eval to some other variable so it always runs in global scope. I don't understand specifics behind this, but seems like easy change and I can confirm it has solved issue.

There is also more elaborate explanation here: http://www.2ality.com/2014/01/eval.html

Really? Just close without any comment? Thanks...