Inconsistent default for pseudo_candidates
gasse opened this issue · comments
Describe the bug
The flag pseudo_candidates is set to False by default in some places, for example in ecole.environment.Branching and ecole.observation.Khalil2016, while it is set to True by default in some other places, for example in ecole.observation.StrongBranchingScores. This can be confusing and lead to unexpected results / behaviors when someone instantiates everything with the default values.
Setting
- Ecole version: 7.0.3
Expected behavior
pseudo_candidates should always be set to False by default, everywhere.
Additional context
See the discussion here.