Genericize EitherMatcher

Question

Genericize EitherMatcher

nicosuave opened this issue 7 years ago · comments

Since both Either and Try implement success?, I suggest modifying Dry::Matcher::EitherMatcher to call success? & failure? rather than right? & left?.

Nico Ritschel · Answer 1 · Tue May 30 2017 06:05:33 GMT+0800 (China Standard Time)

I will submit a PR if this is desired

Tim Riley · Answer 2 · Tue May 30 2017 07:23:28 GMT+0800 (China Standard Time)

@nicosuave I'd love to see this, please go ahead with the PR!

Tim Riley · Answer 3 · Thu Jan 11 2018 06:16:40 GMT+0800 (China Standard Time)

This has been done now.