Support for getting annotations from docstrings
chadrik opened this issue · comments
Hi, me again. I created a tool, called doc484 much like pyannotate, for adding type comments based on docstrings. When I created my tool I was aware of pyannotate but assumed it just about generating annotations from types captured at runtime. Now that I realize it's really two separate tools, I think there are a lot of great features that could be added to pyannotate to make it a one-stop shop for generating/modifying type annotations.
doc484 is also implemented using lib2t3 and would be incredibly easy to add to pyannotate. It implies some additional features, like the ability to specify a fixer that should be considered a source of truth and should thus overwrite existing annotations if they are out of date (and dealing with the ramifications of that in a multi-fixer scenario).
Let me know what you think.
I wonder if the right thing to do isn't for you to just fork pyannotate? Since my retirement from Dropbox I simply don't have the time to review pyannotate contributions any more, and I believe the mypy team at Dropbox also doesn't have that much time to invest.
Well, this repo is owned by Dropbox, and I am no longer a Dropbox employee, so l cannot merge anything. Hence my suggestion to fork.
Also, I've seen your contributions and I have no doubt about your skills or reliability. I suspect that Dropbox will be happy to see this project forked to get new energy and features into it!
I'd hate to fork the project if we can get some momentum going here, and also I don't really want to be on the hook for the runtime part of the project, which I have very little interest in. My plan is to submit a series of PRs here for the issues that I created, and if they get merged then great, otherwise, I'll create a fork of the project under a new name, likely without the runtime part.
Thanks for the guidance. And for.. y'know... python :)
From the resounding silence you can draw your own conclusions. I hope your fork takes flight!