Allow construction of consumer from an existing rationalizer
DrTall opened this issue · comments
That is, let multiple Marshal consumers share a single rationalizer.
Isn't this already true? NewMarshaler is the thing that creates/owns all the rationalizers, and NewConsumer just uses those to claim partitions etc.
Edit: Importantly you can call NewConsumer a bunch of times and you can terminate them etc. Their lifecycle is independent of the marshaler.
Haha I thought when we were on the whiteboard we agreed this needed doing, so I didn't actually verify before filing the ticket. :)
It may be that there is nothing to do here, let me see...
The NewMarshaler makes you specify your client id and group id, so it needs to be refactored.
Oh derp, that was the problem. Carry on!
Mark Smith
mark@qq.is
On Wed, May 11, 2016, at 09:31 AM, Sean wrote:
The NewMarshaler makes you specify your topic and group id, so it
needs to be refactored.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub[1]
Links:
This was done.