Add base Windows image for all plugins
donny-dont opened this issue · comments
There should probably be a base Windows image for all plugins.
@tboerger can you do all the manifest work here?
That way it would be much easier to update the base image, indeed.
Can you work on this? I'm happy to update the windows dockerfiles. Should probably test to see if 1709 images can run on 1803 as well.
I didn't get which version exactly you want to use now, but the branch have been created via be4a2f6, so feel free to provide a proper version within the Dockerfile and maybe you need to change something at appveyor as well?
@tboerger is there a reason you didn't make a Dockerfile.windows?
Yes, so far each architecture got a separate branch, that's why I have simply named it Dockerfile and not Dockerfile.windows.
Gotcha ok well if that changes I'll let you deal with it. Just make the changes? I don't think appveyor is 1709 compatible yet.
https://www.appveyor.com/docs/build-environment/#visual-studio-2017 sounds to me like it should be 1709 compatible? Or did I get it wrong?
Just update the Dockerfile and if required the .appveyor.yml