drivendataorg / concept-to-clinic

ALCF Concept to Clinic Challenge

Home Page:https://concepttoclinic.drivendata.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Race Condition with Timeout Tests

WGierke opened this issue · comments

As discussed in #239 , apparently #243 introduced a race condition that involves tests that should timeout. Sometimes, a TimeoutExit is thrown (which is correctly caught) and sometimes a Termination exception is thrown which is currently now caught and makes the tests fail (e.g. here)

Expected Behavior

A test that creates a timeout should be caught by xfail and thus not fail.

Possible Solution

Only throw TimeoutExit exceptions since there is no reason to throw two kinds of exceptions when a test should be killed.

Checklist before submitting

  • I have confirmed this using the officially supported Docker Compose setup using the local.yml configuration and ensured that I built the containers again and they reflect the most recent version of the project at the HEAD commit on the master branch
  • I have searched through the other currently open issues and am confident this is not a duplicate of an existing bug
  • I filled out all the relevant sections of this template