drivendataorg / cloudpathlib

Python pathlib-style classes for cloud storage services such as Amazon S3, Azure Blob Storage, and Google Cloud Storage.

Home Page:https://cloudpathlib.drivendata.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

glob broken on Python 3.7

Quickblink opened this issue · comments

PR #202 introduced using pathlib internals for the glob implementation which make use of the scandir function as a contextlib.contextmanager. Apparently, pathlib used to work differently (expecting scandir to be an iterator directly) before 3.8 so glob essentially doesn’t work for older python versions. I would suggest dropping support as 3.7 has reached end-of-life status.

I think this is a dupe of #210, not all 3.7.

0.18.1 is already our last 3.7 supporting release:
https://github.com/drivendataorg/cloudpathlib/blob/master/HISTORY.md?plain=1#L13