Giters

driesvints / vat-calculator

Handle all the hard stuff related to EU MOSS tax/vat regulations, the way it should be.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Uniform `VAT` case

manniL opened this issue · comments

commented

Hey 👋
A small not for the next major version:

Currently, there are two ways of writing VAT in the code. The all-uppercase and the capitalized version Vat.

(From the README)

try {
	$validVAT = VatCalculator::isValidVATNumber('NL 123456789 B01');
} catch( VATCheckUnavailableException $e ){
	// Please handle me
}

In my opinion it'd be great to agree on a uniform way of writing the abbreviation ☺️

commented

I think this is a reasonable request but it'd involve breaking changes. I'm not ready to do these right now. But maybe in a future major release we can consolidate the API. Thanks for your suggestion.