Add validation to new-bike form before allowing Add Bike

Question

drewwmercer opened this issue 5 years ago · comments

All fields should be required before entry is allowed. Currently, blank form can be submitted.

Chukwudi M. Ngwobia · Answer 1 · Tue Oct 01 2019 23:56:16 GMT+0800 (China Standard Time)

Can I handle this?

Drew W Mercer · Answer 2 · Wed Oct 02 2019 00:02:41 GMT+0800 (China Standard Time)

That would be great, @chuxmykel

Chukwudi M. Ngwobia · Answer 3 · Wed Oct 02 2019 00:13:54 GMT+0800 (China Standard Time)

I just raised a PR. I'm not sure if there's a convention for the PRs here but I'll make changes if necessary.

Drew W Mercer · Answer 4 · Wed Oct 02 2019 00:41:15 GMT+0800 (China Standard Time)

@chuxmykel this is still allowing form submission even when no fields are filled.

Chukwudi M. Ngwobia · Answer 5 · Wed Oct 02 2019 00:56:37 GMT+0800 (China Standard Time)

Hey @drewwmercer, I'm trying to install the dependencies to test this out but I keep getting this error.

Chukwudi M. Ngwobia · Answer 6 · Wed Oct 02 2019 00:57:53 GMT+0800 (China Standard Time)

Hey @drewwmercer, I'm trying to install the dependencies to test this out but I keep getting this error.

But If I delete the package-lock.json file and install it, it works just fine.

Drew W Mercer · Answer 7 · Wed Oct 02 2019 01:02:40 GMT+0800 (China Standard Time)

It looks like lodash error? When I install locally it has 4.17.10

Chukwudi M. Ngwobia · Answer 8 · Wed Oct 02 2019 01:13:14 GMT+0800 (China Standard Time)

What do you suggest?

Drew W Mercer · Answer 9 · Wed Oct 02 2019 05:40:08 GMT+0800 (China Standard Time)

Are you still seeing the error?

Chukwudi M. Ngwobia · Answer 10 · Wed Oct 02 2019 14:32:33 GMT+0800 (China Standard Time)

Yeah. Does it install successfully on your machine?