Symmetry Mode Not Working
pap1723 opened this issue · comments
When placing a decal, if you place it in symmetry mode, and use a selected image instead of the mission flag, only the placed decal uses the selected image. The opposite symmetry decal is the mission flag.
Having this problem as well. I took a look at the source code, and the ModuleConformalFlag class seems of interest.
I see that SelectFlag() invokes the OnCustomFlagSelected callback whenever the user picks a flag from the browser, which in turns calls both SetFlag() and SetFlagSymmetryCounterparts(). This works fine.
However, OnStart() and OnLoad() only call SetFlag(), not SetFlagSymmetryCounterparts().
I've never made a KSP mod, so I don't know how to modify or compile the plugin to test this, but I am a software engineer, and this is at minimum a good place to start.
Yeah I'm aware of the fix. I was actually in the middle of a refactor that would make the event flows a lot less spaghetti, but then I got burnt out on KSP stuff, and then I started a new job. And here we are a year later. I'll take a look at it soon
@pap1723 Hey I'm not able to reproduce this issue. Can you write some detailed recreation instructions and post them in #36
However,
OnStart()andOnLoad()only callSetFlag(), notSetFlagSymmetryCounterparts().
actually this is fine! OnStart and OnLoad get called for every module, so updating the symmetry counterparts is redundant since they're guaranteed to get the same call