Change Sysdig Agent tagging in init.sh
theluke opened this issue · comments
I hereby propose to update the agent tagging criteria to something more meaningful than insq_date_time.
A possible alternative would be: training_yyyy-mm-dd.
The agent tagging is executed here:
and here:
instruqt-assets/common/prepare-track/init.sh
Line 285 in 0416deb
@Jujuyeh @pabloopez what do you think guys?
LGTM, the instruqt string is only relevant for us. I would even go further for something date-time only like:
$(date -d '+2 hour' +"%F__%H_%M")
in most of cases it is easy to discern what's the cluster that we are seeing data coming from in Sysdig Monitor, but I would also like to see a file with the ${CLUSTER_NAME} value inside. Same location where we store other data and flags.
Thank you @pabloopez .
My feedback comes from the learner standpoint, I would not use just the date, instead training + date would be better.
As for your second comment, I did not understand it ... sorry mate. Can you please clarify?
NP @theluke . Your feedback is welcomed, no need to justify you providing it.
The reason for the insq_ appendix was to keep it sort and easy to see the full clusterName in some fields (Explore, for example, or other menus were you have to select and compare between different cluster). The idea is to keep it short to show all the relevant info, specially time.
Second comment: I am suggesting to get the content of ${CLUSTER_NAME} printed to a file that we can check. Nothing critical, just an small add-on.
Issue moved to draios/instruqt#184