`find_spans()` of `CheckableChunk` only checks for linefeed as newline.

Question

`find_spans()` of `CheckableChunk` only checks for linefeed as newline.

KuabeM opened this issue 4 years ago · comments

Describe the bug

Method find_spans() in chunk.rs only recgonizes a linefeed as newlines, but should also acknowledge CRLF and friends. See FIXME in chunk.rs:219.

To Reproduce

Steps to reproduce the behaviour:

A file containing \r\n as newline
Run cargo spellcheck on that file
find_spans() will be broken

Expected behavior

Everything works on files with \r\n as expected.

Please complete the following information:**

System: Arch Linux
Obtained: git
Version: cargo-spellcheck 0.4.7-alpha.0

Bernhard Schuster commented 3 years ago

Ping 🙃

Korbinian Maier · Answer 1 · Thu Dec 24 2020 06:12:09 GMT+0800 (China Standard Time)

I'm investigating this in branch korbinian-fix-find-spans, I've just pushed a first guess (which isn't working 😞) plus a unit test. I'll open a PR if I found a proper solution.

Korbinian Maier · Answer 2 · Mon Apr 19 2021 19:54:48 GMT+0800 (China Standard Time)

Hopsa, I guess I should have a look again :D thanks for the reminder!

Bernhard Schuster · Answer 3 · Mon Apr 19 2021 22:06:22 GMT+0800 (China Standard Time)

No worries, also #137 ;) - might be easier to do it at all at once

Bernhard Schuster · Answer 4 · Thu May 06 2021 14:39:05 GMT+0800 (China Standard Time)

Any roadblocks I could help with?

Korbinian Maier · Answer 5 · Fri May 07 2021 16:13:02 GMT+0800 (China Standard Time)

Nope, just me not having enough time. As you suggested I'm actually doing #137. It makes more sense to rewrite the whole thing