downshift-js / downshift

🏎 A set of primitives to build simple, flexible, WAI-ARIA compliant React autocomplete, combobox or select dropdown components.

Home Page:http://downshift-js.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CodeSandbox examples broken, and workaround also broken

dantasse opened this issue · comments

Basically reopening #1570. Thanks to @dlong500 for explaining this and describing how to work around it by disabling the "Sandbox beta editor" option. Unfortunately, that option no longer exists, so as far as I can tell, all the examples are inaccessible.

There is a workaround for it - add moduleview=1 to the url params

see codesandbox/codesandbox-client#8350

Yes, the workaround was just released in the last couple weeks. A small PR to the downshift examples index page can update things to work with the new parameter. I'll look into a PR soon.

@dlong500 can you help me understand what do we need to change in the sandbox repo in order to get things working? Thanks!

Closing this as duplicate.

#1570

@dlong500 once we agree on a proper fix I will help to deliver it to the repo.

@silviuaavram I think the only things that needs to get updated at this point is to add ?moduleview=1 to any links pointing to the codesandbox repository, and also to update the language on the index page of the codesandbox repo to get rid of the instructions about changing to "Current Module View".

Oh, and the self-referencing link on the index page of the repo should also include the ?moduleview=1 query parameter for completeness and clarity. As long as that query parameter is present the examples work just fine now that codesandbox added that feature.