douglasduteil / isparta

:skull: A code coverage tool for ES6 (babel/6to5)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Unable to pass include information to istanbul

aukevanleeuwen opened this issue · comments

I was trying to make sure that a certain file was loaded first by isparta / istanbul by passing --include path/to/first.js --include **/*.js, however this didn't seem to 'make it to istanbul'. It seems to go wrong on this line:

includes: opts.includes || config.instrumentation.extensions()

Since ops.includes is read there where the actual option is called ops.include as far as I can tell. I didn't open a pull request since I was unsure whether you wanted to make the cli argument --includes (that would be nicely symmetrical with --excludes) or that you wanted to fix this on the line mentioned above. I would guess the former, however the commandline argument is a 'public api' of course. Then again: I don't think those includes are working anyway.

Probably broke in 941dc51.

Ooops Right !
I'm correcting this typo right now sry

Fixed in isparta@3.5.1

👍 thanks.