Giters

doublecmd / doublecmd

Double Commander is a free cross platform open source file manager with two panels side by side.

Home Page:https://doublecmd.sourceforge.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Internal Viewer Code-mode issues

oldium opened this issue · comments

commented

Version

Double Commander
Version: 1.1.9 beta
Revision: 350
Commit: b220a50
Build date: 2024/01/14
Lazarus: 2.2.6.0
FPC: 3.2.2
Platform: x86_64-Win64-win32/win64
OS version: Windows 11 23H2 x86_64

Description

The Code mode of Internal Viewer looks promising. I have found two issues so far:

  • Dark mode - the highlight colors are sometimes dark too; it seems the Code mode does not have full dark mode support - see screenshot.
  • Viewing large files (like 2GB JSON file) - this takes considerable time to show (Double Commander gets unresponsive), so it could be good to limit the Code mode display by some configurable size limit

image

commented

It should has a full dark mode support. Which highlighter do you use?

commented

Thanks for the pointer. I am not using internal Editor (I use external one - Notepad++), so I have not touched any highlighting. But I checked how it behaves in my second account, which I use rarely (here I update Double Commander less often). On my second account the colors look good (same version). So I compared AppData/Roaming/doublecmd and found lot of differences in colors.json - maybe some relics from older version (I have been using Double Commander snapshots for years). Is it safe to delete the file to get the defaults or how to proceed with the color reset?

commented

If you does not have a custom color settings then you can remove colors.json, otherwise you can remove Highlightes/UniHighlighters sections from colors.json. Both actions should be done with closed DC.

commented

Deleted colors.json and now it looks good. Thanks. So the only issue now is support for opening really large files.

image

commented

Should I create a separate issue for the viewing of large files? The color issue is now fixed for me, so this issue could be closed afterwards.

commented

File size limit is a feature request.

commented

Yes, I know. GitHub knows only Issues. But I asked about something else - whether you want to keep the “feature request” separately or whether you are fine that it is mentioned here together with the color problem, which is fixed for me.