Giters

dotnet / msbuild

The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.

Home Page:https://docs.microsoft.com/visualstudio/msbuild/msbuild

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[GB18030] Audit shipped props and targets for usage of Substring on paths

JanKrivanek opened this issue · comments

commented

Context

Based on issue identified by @ilonatommy and @ladipro (#10063)
Substring doesn't resect surrogate chars

Sample GH query (though needs to be tunned up, or just search locally): https://github.com/search?q=Substring+repo%3Adotnet%2Fmsbuild+path%3A**%2F*.targets&type=code&ref=advsearch

commented

In msbuild we have just the single usage being fixed.

There are couple similar usages in Blazor targets in sdk: https://github.com/search?q=repo%3Adotnet%2Fsdk+path%3A**%2F*.targets+substring&type=code

Once the fix is inserted we should reach out to them or shoot a PR