dotnet / format

Home for the dotnet-format command

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Eliminate Microsoft.Build.Locator source-build prebuilt

MichaelSimons opened this issue · comments

During source-build the following package is being reported as a prebuilt in 7.0.2xx.

<Usage Id="Microsoft.Build.Locator" Version="1.5.5" File="src/format/artifacts/source-build/self/src/artifacts/obj/dotnet-format/project.assets.json" IsDirectDependency="true" />

This package is produced as part of the source-build graph but not version 1.5.5. To fix this, dotnet-format should utilizing a versions.props property to define the version number so that it can be overridden by source-build to the version it builds. In other words use the pattern used to define the Microsoft.Build version.

@JoeRobich, I noticed the release/7.0.2xx branch of the SDK contains a dotnet/format commit from it's main branch not the release/7.0 branch. Is this intentional? If the 7.0.2xx SDK contains the release/7.0 dotnet/format, the version of Microsoft.Build.Locator reference by dotnet/format would align with the version produced by source-build and this wouldn't be an issue.

cc @jasonmalinowski - We are also seeing the main version flow into 7.0.1xx. This is a blocker for source build. Can you please advise.