[0.5d] pushPeerState should set status to include bytes transferred
lukemarsden opened this issue · comments
currently it shows as running, 1 commits
, but ideally it should include MB/sec and MB transferred
pkg/fsm/fsm_push_peer.go
probably gets this in case <-receiveProgress
but throws it away, could set status in f.transitionedTo("pushPeerState", "<insert status here>")
instead
important because polish is important
needs a UI change in the frontend when workspace-status is rendered.
Please describe the UI change in the frontend that you'd like!
Relates to https://github.com/dotmesh-io/frontend-ng/issues/625
In addition to the fixes in that issue, should show the new info available thanks to this issue in that same grey bar
So like "Synchronizing data with runner, 213.2/342.3MB at 12.2MB/sec..."
Ok, as far as I can tell, the UI is based on the status info in the DotmeshRPC.Get call, which looks like this during a push:
{
"Branch": "",
"CommitCount": 2,
"DirtyBytes": 0,
"ForkParentId": "",
"ForkParentSnapshotId": "",
"Id": "52852187-8727-435c-9058-7a15c092059e",
"Master": "448ae8dedf5bdced",
"Name": {
"Name": "pushtest",
"Namespace": "admin"
},
"ServerStates": {
"448ae8dedf5bdced": "pushPeerState"
},
"ServerStatuses": {
"448ae8dedf5bdced": "running: 588.156 MiB so far, 193.236 MiB/sec, 2 commits"
},
"SizeBytes": 2811087872
}
Done in dotmesh version 8922c68