[0.5d] pushPeerState should set status to include bytes transferred

Question

[0.5d] pushPeerState should set status to include bytes transferred

lukemarsden opened this issue 5 years ago · comments

currently it shows as running, 1 commits, but ideally it should include MB/sec and MB transferred

pkg/fsm/fsm_push_peer.go probably gets this in case <-receiveProgress but throws it away, could set status in f.transitionedTo("pushPeerState", "<insert status here>") instead

lukemarsden · Answer 1 · Thu Jun 27 2019 15:23:45 GMT+0800 (China Standard Time)

important because polish is important

lukemarsden · Answer 2 · Tue Jul 30 2019 22:20:59 GMT+0800 (China Standard Time)

needs a UI change in the frontend when workspace-status is rendered.

alaric-dotmesh · Answer 3 · Thu Aug 01 2019 00:45:44 GMT+0800 (China Standard Time)

Please describe the UI change in the frontend that you'd like!

lukemarsden · Answer 4 · Thu Aug 01 2019 01:50:50 GMT+0800 (China Standard Time)

Relates to https://github.com/dotmesh-io/frontend-ng/issues/625

In addition to the fixes in that issue, should show the new info available thanks to this issue in that same grey bar

So like "Synchronizing data with runner, 213.2/342.3MB at 12.2MB/sec..."

alaric-dotmesh · Answer 5 · Thu Aug 08 2019 18:20:32 GMT+0800 (China Standard Time)

Ok, as far as I can tell, the UI is based on the status info in the DotmeshRPC.Get call, which looks like this during a push:

{
  "Branch": "",
  "CommitCount": 2,
  "DirtyBytes": 0,
  "ForkParentId": "",
  "ForkParentSnapshotId": "",
  "Id": "52852187-8727-435c-9058-7a15c092059e",
  "Master": "448ae8dedf5bdced",
  "Name": {
    "Name": "pushtest",
    "Namespace": "admin"
  },
  "ServerStates": {
    "448ae8dedf5bdced": "pushPeerState"
  },
  "ServerStatuses": {
    "448ae8dedf5bdced": "running: 588.156 MiB so far, 193.236 MiB/sec, 2 commits"
  },
  "SizeBytes": 2811087872
}

alaric-dotmesh · Answer 6 · Thu Aug 08 2019 23:12:24 GMT+0800 (China Standard Time)

Done in dotmesh version 8922c68