doowb / npm-api

Node.js library for getting info from NPM’s API

Home Page:https://github.com/doowb/npm-api

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove `request`

doowb opened this issue · comments

request could be removed since this module doesn't need the flexibility for the entire request module.

This module still needs to handle streaming the response so I've considered figuring out a way to use http(s) directly or something like superagent.

request package is now deprecated. @doowb would a PR moving this to http(s) module be welcome?

Yes, that would be great!

I'm not sure why I closed this issue since request is still being used.

UPD: I think I'll use node-fetch for non-streamed requests and https for streamed ones

Unfortunately, I won't be able to check that view.query() still works until #13 is fixed

No problem. NPM changed some things and I'm not sure if the CouchDB API that view and list use is available anymore.
As long as the package related methods work, that works for me... I need to get unit tests in here and make some other updates anyway.