Crash if completion block is nil

Question

Crash if completion block is nil

reydanro opened this issue 9 years ago · comments

If I present the feedback dialog with a nil completion block, the sdk will crash in the [Doorbell finish] method when calling self.block(nil, NO).

Please note that I am using the sdk in a Swift project.

Philip Manavopoulos · Answer 1 · Thu May 28 2015 17:50:30 GMT+0800 (China Standard Time)

Thanks for reporting! Will try and have a look at this!

Didn't even know you can use it in a Swift project, would definitely love to hear more about that!

Andrei Stanescu · Answer 2 · Fri May 29 2015 03:09:55 GMT+0800 (China Standard Time)

I hot-fixed the bug by testing if self.block is not nil before calling it.
PS: On the swift matter, I commented on the other ticket.

Philip Manavopoulos · Answer 3 · Mon Jun 01 2015 17:56:35 GMT+0800 (China Standard Time)

Thanks for debugging this! I'll have a look and see if I can make that code to behave well for ObjC and Swift!