Swift support

Question

Swift support

reydanro opened this issue 9 years ago · comments

Any plans or actively working towards a Doorbell SDKin Swift?
Wondering if I should start porting the current ObjC one.

Philip Manavopoulos · Answer 1 · Wed May 27 2015 07:03:40 GMT+0800 (China Standard Time)

Would love to, but don't have the time for it at the moment. Would be awesome if you were able to port it, would be happy to link to it from doorbell! :-)

Andrei Stanescu · Answer 2 · Fri May 29 2015 03:12:12 GMT+0800 (China Standard Time)

As a fast solution I ended up using the ObjC sdk in the swift project and it was very easy to integrate.
So easy, that I think it becomes questionable whether a pure swift implementation is really needed. It would also mean double the work on updates or bug fixes.

Philip Manavopoulos · Answer 3 · Fri May 29 2015 04:57:25 GMT+0800 (China Standard Time)

Great to hear that it's easy to integrate! Not having twice the work is definitely a nice benefit! Any instructions/tutorials on how to set it up? Would love to mention it in Doorbell that it works with Swift projects as well! Thanks!

Andrei Stanescu · Answer 4 · Fri May 29 2015 06:12:04 GMT+0800 (China Standard Time)

It's the standard way of using any ObjC class in Swift.
You need to setup a bridging header, import the two headers from Doorbell SDK and then when you want to display the dialog you can do something like this:

    var feedback = Doorbell(apiKey: "", appId: "")
    feedback.showFeedbackDialogInViewController(self, completion: nil)

My suggestion would be to add a new repo on github with a sample project in swift. Can't get more clear than that for new users :)

Thanks too

Philip Manavopoulos · Answer 5 · Mon Jun 01 2015 17:55:50 GMT+0800 (China Standard Time)

Awesome, will try and do that :)

I'll close this once I have the demo repo ready!

Thanks again!

yarrichar · Answer 6 · Thu Mar 29 2018 10:18:01 GMT+0800 (China Standard Time)

What is the podfile entry for doorbell? I've tried adding:
pod 'doorbell/ios-sdk'
But that didnt work.

Philip Manavopoulos · Answer 7 · Thu Mar 29 2018 20:02:16 GMT+0800 (China Standard Time)

You need to use pod 'Doorbell', '~> 0.1'

Bhavin · Answer 8 · Fri Mar 30 2018 12:13:43 GMT+0800 (China Standard Time)

@manavo I can translate this into swift if you want and is this sdk connected via wifi too?

Philip Manavopoulos · Answer 9 · Fri Mar 30 2018 20:12:56 GMT+0800 (China Standard Time)

Thanks for the offer, but since it does already work with Swift it probably isn't needed.

Not sure I understand what you mean by asking if it connects via wifi though?

yarrichar · Answer 10 · Mon Apr 02 2018 08:22:21 GMT+0800 (China Standard Time)

If I could add my 2 cents. It works on Swift if you add the bridging headers etc. This is the only library that I use (and pay for) where I have to do that. It would definitely reduce the barrier to entry if there was a swift version where that wasn't necessary.

Philip Manavopoulos · Answer 11 · Tue Apr 03 2018 01:27:03 GMT+0800 (China Standard Time)

I definitely agree it isn't ideal, just hard to try and support both Objective C and Swift. Longer term Objective C will die out (I assume), but for now it is important to support both.

I need to look into the opposite being an option, importing a Swift library into Objective C. If that's an option, it might warrant a rewrite from ObjC to Swift for the SDK. Needs investigating first though.

Maintaining both SDKs in parallel would be a fair bit of work!

yarrichar · Answer 12 · Tue Apr 03 2018 05:30:23 GMT+0800 (China Standard Time)

Yeah, fair enough. Good plan.

Philip Manavopoulos · Answer 13 · Tue Apr 09 2019 23:25:47 GMT+0800 (China Standard Time)

It's taken a while, but with Cocoapods having use_frameworks! the bridging headers aren't needed anymore. I've also updated all the documentation to include both Swift and Objective C, so I'll close this now! Sorry it has taken so long!