donnemartin / interactive-coding-challenges

120+ interactive Python coding interview challenges (algorithms and data structures). Includes Anki flashcards.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

may compressing a string challenge improved?

muatik opened this issue · comments

In http://nbviewer.ipython.org/github/donnemartin/interactive-coding-challenges/blob/master/arrays_strings/rotation/rotation_challenge.ipynb, I think that for better compressing single characters may be left as they are. For example "AAABCCDDDD" is expected to be compressed as "A3B1C2D4"; however, "A3BCCD4" looks like to me a better compressing.

@muatik good catch, interested in submitting a pull request? :)

Hey, @donnemartin, in case @muatik isn't working on this, may I try? I am comparatively new to python and think that this is on my level.

I will prepare a pull request @donnemartin

@hashhar you should try. each person may accomplish a task differently, sometimes in a better way.

if you are interested in my solution, you can follow this link: https://github.com/muatik/my-coding-challenges/blob/master/challenges-string-compress.ipynb

@muatik Thanks. I'll try on my own and if I seem to get stuck, I'll see.

Great, looks like you guys sorted this out 👍

Merged #39.