donnemartin / gitsome

A supercharged Git/GitHub command line interface (CLI). An official integration for GitHub and GitHub Enterprise: https://github.com/works-with/category/desktop-tools

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

should pyzmq be listed in setup.py or requirements,txt?

suliuzh opened this issue · comments

Hi
I am wondering if pyzmq should be listed in setup.py or requirements,txt?
As we can see, pyzmq is used in xonsh/jupyter_kernel.py as a must. But when I use "pip install gitsome", it seems that pyzmq will not be installed automatically. So should pyzmq be listed as dependency?
image