Able to add a negative `amount` for `add` command
domlimm opened this issue · comments
Steps to reproduce:
Similar to Issue #4 on the edit command.
User is able to add a negative amount when adding an expense into the app.
add d/testing negative a/-1 t/2022-04-16
Expected:
A non-negative amount when adding an expense.
Actual:
Team's Response
Rejected because it is a feature flaw, not a functionality bug. In addition, this feature flaw will not affect the functionality of the application, it will just render one expense invalid due to negative value and user can re-key the value. Hence, the severity should not be high too.
Items for the Tester to Verify
❓ Issue response
Team chose [response.Rejected]
- I disagree
Reason for disagreement: Once again, sorry. I might have mixed up FeatureBug and FunctionalityBug. Agree on the change for type and severity of the issue.
However, it should still be accepted as a bug. Yes, it will not affect the functionality of the application. But in a real world application, an expense would not be negative.
And as the dev team has said, which would already cause a problem.
... it will just render one expense invalid due to negative value ...
That was the point of the bug report. In my opinion, should not be rejected because of wrong tagging.
Again, sorry for the wrong tagging!
Also, as mentioned by prof here, should not be rejected because of the wrong bug type.
❓ Issue type
Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]
- I disagree
Reason for disagreement: [replace this with your explanation]
❓ Issue severity
Team chose [severity.Medium]
Originally [severity.High]
- I disagree
Reason for disagreement: [replace this with your explanation]