domlimm / pe

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

DG - Model section

domlimm opened this issue · comments

Curious as to why UniqueExpenseCategoryList is not associated with any other classes.

image.png

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Model component in DG has inconsistent UML diagram

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



The explanation below talks about the Expense Category objects being contained in the UniqueExpenseCategoryList, but the diagram shows otherwise. Firstly there is a floating UniqueExpenseCategoryList, which I believe does not exist in your codebase, at least not in tp/src/main/java/seedu/address/model/expense/.

image.png

Secondly, the Expense Category objects are contained by ExpenseCategoryList, which I believe is different from what you have explained in the DG.

image.png


[original: nus-cs2103-AY2122S2/pe-interim#3226] [original labels: severity.Medium type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Team agrees that the error in variable naming could result in the possibility that the developer might not be able to understand, but would like to state that developer normally will read code, hence, will be able to understand that such error is due to typo.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: [replace this with your explanation]