Tests fail
rubik opened this issue · comments
Michele Lacchia commented
Describe the bug
Make fails to build because the tests fail:
$ make
"go" build -o "kubeip"
"go" test -race -v github.com/doitintl/kubeip github.com/doitintl/kubeip/pkg/client github.com/doitintl/kubeip/pkg/config github.com/doitintl/kubeip/pkg/controller github.com/doitintl/kubeip/pkg/kipcompute github.com/doitintl/kubeip/pkg/types github.com/doitintl/kubeip/pkg/utils
# github.com/doitintl/kubeip/pkg/controller
pkg/controller/controller.go:311:4: Infof call needs 1 arg but has 2 args
? github.com/doitintl/kubeip [no test files]
? github.com/doitintl/kubeip/pkg/client [no test files]
? github.com/doitintl/kubeip/pkg/config [no test files]
make: *** [Makefile:19: test] Error 2
To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/doitintl/kubeip
cd kubeip
make
- See error
Expected behavior
The build should succeed.
Desktop (please complete the following information):
- OS: ArchLinux
Aviv Laufer commented
@rubik it fails because we don't have any tests. I removed the line from the makefile