doitintl / kubeip

Assign static public IPs to Kubernetes nodes (GKE, EKS)

Home Page:https://kubeip.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Exposing liveness and readiness k8s probes

bygui86 opened this issue · comments

hi everybody

KubeIP is a great tool, but it lacks one important thing: k8s probes.

What about implementing live- and readiness?

KubeIP works a daemonset and runs only once (replaces IP and does nothing till node shutdown). If K8s had a DaemonJob, I would use it instead.
The liveness probe helps you to understand if service is up an running - not relevant for KubeIP
The readiness probe says that service is ready to accept traffic - also not relevant for KubeIP

hi @alexei-led thanks for your reply.
I agree with you that readiness probe does not make sense, sorry for the proposal.
About liveness probe I was thinking that KubeIP would perform a check every so often, but if it's a one-shot action at the startup then nothing.
I will open another issue to propose an enhancement to have KubeIP perform a checking loop every so often to detect and fix possible drifts.
thanks