documentcloud / wordpress-documentcloud

Embed DocumentCloud documents that won't be eaten by the visual editor

Home Page:https://wordpress.org/plugins/documentcloud/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add responsive options to shortcode

eyeseast opened this issue · comments

Now that @documentcloud is moving towards a responsive viewer (documentcloud/document-viewer#46) we should add the options to the shortcode. Question is, should embeds be responsive by default?

+1 to the option being added, but it's not ready yet to be the default.

Offline consensus is that we can indeed default to responsive. Making it so.

Seems reasonable to me, too.

On Tue, Apr 28, 2015 at 2:48 PM, Justin Reese notifications@github.com
wrote:

Offline consensus is that we can indeed default to responsive. Making it
so.


Reply to this email directly or view it on GitHub
#14 (comment)
.

Chris Amico
Glass Eye Media LLC http://glasseyemedia.org

I just realized this means width/maxwidth effectively have no impact unless you set responsive:false. Guess we should document that.