Math seems a little wrong.
jashkenas opened this issue · comments
Very much enjoying the new responsive notes feature. ... but it seems like the calculation of the bounding box could use a little work.
Using the Willingham story:
http://www.themarshallproject.org/2014/08/03/did-texas-execute-an-innocent-man-willingham/
Here's some screenshots of how the clipping changes as you resize the page. Ideally, the visible text would be identical in each one. Also, the centering.
@knowtheory asked me to look into this while he's traveling, I expect he'll chime in once he's able. Also pinging @tommeagher on it.
It looks to me like there's two resize handlers that are both attempting to resize the notes. Our responsive note handler and also a handler that's contained in compiled all-b14e24a8.js.
All I'm going on is the pretty-printed source from chrome, but it looks like the all-b14e24a8.js file is resizing the .DC-left-cover and .DC-right-cover divs, while our resize handler is adjusting the img.DC-note-image position.
Here's the article at the Washington Post where the annotations do appear correct: http://www.washingtonpost.com/sf/national/2014/08/03/fresh-doubts-over-a-texas-execution/
You're right -- that WP version is looking just fine.
Oh how regretful. I suspect that is actually a process failure on our part.
Check out the Washington posts version of the story. They pulled out their
responsive shim after the code went live, and I suspect that the Marshall
Project's page still has it included, so the notes are over-responsive.
I'm having a hard time with airport wifi so I'm just going to cc/ @tommeagher here.
On Thursday, September 25, 2014, Jeremy Ashkenas notifications@github.com
wrote:
Very much enjoying the new responsive notes feature. ... but it seems like
the calculation of the bounding box could use a little work.Using the Willingham story:
http://www.themarshallproject.org/2014/08/03/did-texas-execute-an-innocent-man-willingham/
Here's some screenshots of how the clipping changes as you resize the
page. Ideally, the visible text would be identical in each one. Also, the
centering.[image: image]
https://cloud.githubusercontent.com/assets/4732/4406039/fb04453a-44bf-11e4-9b24-820594bcc806.png[image: image]
https://cloud.githubusercontent.com/assets/4732/4406048/0fa5461a-44c0-11e4-926c-efd6653ac439.png[image: image]
https://cloud.githubusercontent.com/assets/4732/4406052/18af7d2a-44c0-11e4-8bae-ee53660f17c4.png[image: image]
https://cloud.githubusercontent.com/assets/4732/4406056/2184ad6c-44c0-11e4-9cdf-d3540e77b3e9.png[image: image]
https://cloud.githubusercontent.com/assets/4732/4406061/2c2765de-44c0-11e4-84f6-ef2feeafce49.png—
Reply to this email directly or view it on GitHub
#2.
Well, looks like my email just went through :P
I just deployed with the WP code removed. I think everything is resolved.
@knowtheory, I actually got a heads up about this from Emily but (obviously) hadn't yet done it, so no worries.
👌 🍻
Thanks guys :)