docker / docker-py

A Python library for the Docker Engine API

Home Page:https://docker-py.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support --stop-timeout in create and run request

cweber-dbs opened this issue · comments

Issue #2449 was closed without merging the PR (#2909) . So this parameter is still missing.

Original issue:

API 1.25 added the --stop-timeout to the run command. It needs to be added to the docker API. https://docs.docker.com/engine/api/v1.25/#

Otherwise I received the following error:
TypeError: run() got an unexpected keyword argument 'stop_timeout'

There might be an other issue in the error handling in _create_container_args

    # All kwargs should have been consumed by this point, so raise
    # error if any are left
    if kwargs:
        raise create_unexpected_kwargs_error('run', kwargs)

The first parameter of create_unexpected_kwargs_error should be create due to the fact, that _create_container_args is only called by the container.create function.