Screenshots for React-Java-MySQL are off
JalexChen opened this issue · comments
I understand this is a very small issue but the screenshots in the README for the mentioned directory is a bit off and/or outdated, and I only ran into this when my CI build was failing as a result.
I was testing for react-java-mysql_backend when in reality, the container was named react-java-mysql-backend
Might be a coincidence but my lead posted a relevant article just today which I thought was humorous: https://joshtronic.com/2022/08/21/screenshots-are-not-documentation/
Thank you Docker team for providing this repository! :)
You're right, good eye! A lot of the READMEs appear to show output from compose v1. In compose v2 we're using dashes instead of underscores for image and container names. The format is a bit different as well. Would you mind submitting a PR for those changes? A lot of the samples need updating, but feel free to just update the react-java-mysql one.
Sure thing. I thought they were screenshots initially but I've just submitted a PR