docker-library / python

Docker Official Image packaging for Python

Home Page:https://www.python.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feat: include git in windows images

mutricyl opened this issue · comments

I am using python docker image for my windows gitlab runner and I would need to use git and python within my gitlab pipelines.

My docker skills are very limited and I would not be confident storing my experimental image on dockerhub.

As windows pyhton image are already quite large in size, I seems to me that adding git by default is not such a big deal. So I was wondering if you could include git in you windows images?

Thanks for the request! Unfortunately, I don't think I'm comfortable adding this, but you might take inspriration from https://github.com/docker-library/golang/blob/eb57429622f401af7c5afffeb3cd88022c9b9782/1.22/windows/windowsservercore-ltsc2022/Dockerfile#L12-L44 in adding it to your own images.

(Even that installation is something we should reconsider given that Go prefers to use the proxy instead of Git now.)

Ok, thanks for the tip.