docker-archive / communitytools-image2docker-win

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Convert-WindowsImage is the name of another tool for ISO -> VHD conversion

PatrickLang opened this issue · comments

Convert-WindowsImage is already well known commandlet used to convert Windows ISO images to VHD/VHDX: https://gallery.technet.microsoft.com/scriptcenter/Convert-WindowsImageps1-0fe23a8f

All commandlets are supposed to have a verb-noun format, so I think something like Create-Dockerfile or ConvertTo-Dockerfile would make more sense to avoid confusion with the existing Convert-WindowsImage

@pcgeek86 What do you think?

@PatrickLang @ManoMarks The Convert-WindowsImage PowerShell script that is referred to isn't in the core PowerShell experience. It's a third-party script hosted on a community repository. We can still go ahead and rename the command to ConvertTo-Dockerfile. That seems more appropriate.

@pcgeek86 +1 - ConvertTo is in the approved list

Fixed in this commit

7acd572